fix: Don't prevent rendering if buffer is empty#597
Closed
mrjones2014 wants to merge 1 commit intoMeanderingProgrammer:mainfrom
Closed
fix: Don't prevent rendering if buffer is empty#597mrjones2014 wants to merge 1 commit intoMeanderingProgrammer:mainfrom
mrjones2014 wants to merge 1 commit intoMeanderingProgrammer:mainfrom
Conversation
Owner
|
This behavior is intentional and made to support LSP hover docs in older versions of neovim: 059f503 |
Author
|
Hm okay interesting. Can you think of a different way to fix this issue? Basically it leaves codeblock headers around if the buffer is cleared programmatically. |
MeanderingProgrammer
added a commit
that referenced
this pull request
Feb 22, 2026
## Details Issue: #597 Since we entirely skip rendering empty buffers if a buffer is cleared it can cause extmarks to be left behind and not cleaned up. Skipping empty buffers was added to fix how LSP hover buffers were created, where they were initially empty, then later content was added. However due to this order the debounce would skip rendering the latter. To fix all of these interactions we now simply do not debounce when rendering an empty buffer. As a result any decorations left should now be properly cleaned up and content being added later should not get skipped via the debounce.
Owner
|
This should be fixed by: 1c95813 We now no longer skip rendering empty buffers and to still handle the old LSP hover docs case empty buffer renders are no longer debounced. LMK if that resolves the issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this: sudo-tee/opencode.nvim#200
Is actually a bug with this plugin.
If the text is non-empty, then is changed to empty via
vim.api.nvim_buf_set_lines(buf, 0, -1, false, {}),render-markdown.nvimshould still render in that case, otherwise it leaves behind some extmarks (I think those are extmarks)?